[Platform] Remove default model names from constructor parameters #653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OskarStark
commented
Sep 23, 2025
OskarStark
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| Docs? | no |
| Issues | Forgotten in #577 |
| License | MIT |
carsonbot
added
Feature
OskarStark
changed the title
OskarStark
force-pushed
the
no-defaults
branch
from
84c107c to
665b7f5
Compare
OskarStark
force-pushed
the
no-defaults
branch
from
b67579c to
70e86c2
Compare
OskarStark
added a commit
that referenced
this pull request
Sep 23, 2025
… (OskarStark) This PR was merged into the main branch. Discussion ---------- [Platform] Remove default values from model constructors | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | Docs? | no | Issues | Follows #653 | License | MIT Remove hardcoded max_tokens defaults from Claude and Nova model classes to prevent potential BC breaks when these values might change in future versions. Users should explicitly specify max_tokens if needed. Commits ------- f921029 Remove default max_tokens values from model constructors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.