[AI Bundle] Improvement on alias for store #641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guikingone
requested review from
chr-hertel,
Nyholm and
OskarStark
as code owners
|
So I would have to use |
OskarStark
reviewed
Sep 21, 2025
|
What about registering both? The long and the short version? I would argue, that this is not really common use case, right? Also docs would need an update |
|
@chr-hertel Yes @OskarStark Yes, agree on the fact that it's not a common approach (even if it can be used when you're migrating from one to another), registering both is fine for me if @chr-hertel agreed on it 👍🏻 |
Guikingone
force-pushed
the
refactor/store_alias
branch
from
a24ad5c to
a252cc5
Compare
OskarStark
changed the title
carsonbot
changed the title
Guikingone
force-pushed
the
refactor/store_alias
branch
from
a252cc5 to
8865f21
Compare
|
Thank you @Guikingone. |
OskarStark
added a commit
that referenced
this pull request
Sep 23, 2025
…t (OskarStark) This PR was squashed before being merged into the main branch. Discussion ---------- [AI Bundle] Document store dependency injection improvement | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Docs? | yes | Issues | Follows #641 | License | MIT Add documentation for the improved store alias functionality that allows multiple stores with the same name across different types. The feature provides both simple aliases and type-prefixed aliases for flexible dependency injection without conflicts. Commits ------- 46d92ab [AI Bundle] Document store dependency injection improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋🏻
A small improvement for the store alias, this approach allows to use the same name for various store (like
foofor a memory one, a qdrant one, etc) without injection issues.