[AI Bundle] Document store dependency injection improvement #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
AI Bundle
OskarStark
commented
Sep 23, 2025
src/ai-bundle/doc/index.rst
Outdated
| { | ||
| public function __construct( | ||
| private StoreInterface $main, // Uses memory store (first occurrence) | ||
| private StoreInterface $weaviate_main, // Explicitly uses weaviate store |
There was a problem hiding this comment.
I am wondering if this should be $weaviateMain @Guikingone
There was a problem hiding this comment.
Agree, in the version you pushed, it could be:
private StoreInterface $chromaDbMain # Not sure about `Db`There was a problem hiding this comment.
I was working on the documentation before you merged, I'm slow 😅
There was a problem hiding this comment.
Agree, in the version you pushed, it could be:
So should I change that?
There was a problem hiding this comment.
I would change it to chromaDbMain, it respects the PSRs and Symfony style guideline, not a fan of the foo_bar syntax 🤔
There was a problem hiding this comment.
If it is working, ok 😄
OskarStark
added a commit
to OskarStark/ai
that referenced
this pull request
Sep 23, 2025
Eliminate code duplication in options.php by introducing an $addModelNode closure that handles model configuration for both agent and vectorizer sections. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
OskarStark
force-pushed
the
feature/store-alias-documentation
branch
from
a53c76d to
46d92ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation for the improved store alias functionality that allows multiple stores with the same name across different types. The feature provides both simple aliases and type-prefixed aliases for flexible dependency injection without conflicts.