Skip to content

[Platform] Remove default values from model constructors #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2025
+2 −2
Merged

[Platform] Remove default values from model constructors #654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/platform/src/Bridge/Anthropic/Claude.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class Claude extends Model
*/
public function __construct(
string $name,
array $options = ['max_tokens' => 1000],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setting max_tokens is actually needed - if you mind the value here, we could set it in the ModelClient instead, but we need to have a default to have the API similar to the other models.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why this is needed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not mee - it's them :D

https://docs.claude.com/en/api/messages#body-max-tokens

array $options = [],
) {
$capabilities = [
Capability::INPUT_MESSAGES,
Expand Down
2 changes: 1 addition & 1 deletion src/platform/src/Bridge/Bedrock/Nova/Nova.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ final class Nova extends Model
*/
public function __construct(
string $name,
array $options = ['max_tokens' => 1000],
array $options = [],
) {
$capabilities = [
Capability::INPUT_MESSAGES,
Expand Down