[Platform] Remove default values from model constructors #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Feature
Remove hardcoded max_tokens defaults from Claude and Nova model classes to prevent potential BC breaks when these values might change in future versions. Users should explicitly specify max_tokens if needed.
OskarStark
force-pushed
the
no-default-options
branch
from
b1dc080 to
f921029
Compare
chr-hertel
reviewed
Sep 23, 2025
| */ | ||
| public function __construct( | ||
| string $name, | ||
| array $options = ['max_tokens' => 1000], |
There was a problem hiding this comment.
setting max_tokens is actually needed - if you mind the value here, we could set it in the ModelClient instead, but we need to have a default to have the API similar to the other models.
There was a problem hiding this comment.
Can you explain why this is needed?
There was a problem hiding this comment.
it's not mee - it's them :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove hardcoded max_tokens defaults from Claude and Nova model classes to prevent potential BC breaks when these values might change in future versions. Users should explicitly specify max_tokens if needed.