Added a Paginator object based on Doctrine's paginator #1006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bocharsky-bw
approved these changes
Jul 3, 2019
stof
reviewed
Jul 3, 2019
stof
reviewed
Jul 3, 2019
|
Hi, Thank for symfony/demo. I learn so many with it. |
javiereguiluz
added a commit
that referenced
this pull request
Jul 24, 2019
…(javiereguiluz) This PR was squashed before being merged into the master branch (closes #1006). Discussion ---------- Added a Paginator object based on Doctrine's paginator The current code uses an array to provide the pagination information. We did that as part of the quick proof-of-concept replacement of Pagerfanta library. This PR proposes to replace that array by a proper object. The new design was based on the one proposed by EasyAdmin to also replace Pagerfanta (EasyCorp/EasyAdminBundle#2777). Commits ------- 7a9e13e Added a Paginator object based on Doctrine's paginator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code uses an array to provide the pagination information. We did that as part of the quick proof-of-concept replacement of Pagerfanta library.
This PR proposes to replace that array by a proper object. The new design was based on the one proposed by EasyAdmin to also replace Pagerfanta (EasyCorp/EasyAdminBundle#2777).