Update bootswatch and bootstrap dependencies

[abdounikarim]

Hey guys,

I think i've finished this PR #1029

Here is what I did :

1. Update dependencies :

• bootstrap (to version 4)
• bootswatch (to version 4)

2. Replace dependencies :

• bootstrap-sass by Bootstrap updated version
• eonasdan-bootstrap-datetimepicker by tempusdominus-bootstrap-4

3. Update assets :

• replace bootstrap-sass/assets/javascripts/bootstrap/transition.js by bootstrap/scss/transitions

4. Remove unused dependencies :

• [bootstrap-sass] (https://yarnpkg.com/en/package/bootstrap-sass)
• eonasdan-bootstrap-datetimepicker

5. Update templates in templates directory (sorry if i miss something)

6. CSS :
   well class not replaced (not existing in the new Flatly theme

7. Generate new files for production with yarn build

Let me know if i miss something please, thank you 😉

[noniagriconomie]

@abdounikarim do you have any before/after pics?
nice work btw!

[mazarini]

Hi,
There is something use with twig for bootstrap :

twig:
    form_themes: ['bootstrap_4_layout.html.twig']

Actually, demo use :

twig:
    form_themes:
        - 'form/layout.html.twig'
        - 'form/fields.html.twig'

I don't known if it(s nedd change.

[javiereguiluz]

@abdounikarim thanks a lot for your contribution. All the steps you outlined look OK to me. However, when testing this pull request, I found that it looks very different from before. I expected some changes, because we're upgrading from Bootstrap 3 to 4 and the template is also upgraded ... but some things look wrong. Here are some before/after comparisons:

Comparison 1

Before

After

Comparison 2

Before

After

Comparison 3

Before

After

Comparison 4

Before

After

Comparison 5

Before

After

[abdounikarim]

@javiereguiluz hello, as i was told you on Slack, the Flatly theme was updated and there are some differences. For example :

• the h1 has now a font-size with 3em (before he has a font-size with 39px)
• there is no longer well class
  i'm gonna correct this to look like the actual theme in Symfony Demo"

[abdounikarim]

@javiereguiluz i think i just finished design corrections. Can you check and tell me please ?
Cheers 😉

[stof]

* bootstrap-sass/assets/javascripts/bootstrap/transition.js by bootstrap/scss/transitions

replacing a JS file by a SCSS one ? Isn't that a mistake ?

[abdounikarim]

* bootstrap-sass/assets/javascripts/bootstrap/transition.js by bootstrap/scss/transitions

replacing a JS file by a SCSS one ? Isn't that a mistake ?

hey @stof , i didn't find any transition.js file in the bootstrap directory.

[abdounikarim]

@stof i think i'm good now. cheers 😉

[abdounikarim]

@javiereguiluz are we good now ? or do you want any change ? 😉

[stof]

isn't this already imported by the main bootstrap file ?

[javiereguiluz]

Closing as fixed in #1412 (and #1183).

@abdounikarim I'm really sorry this contribution wasn't merged. I apologize for it and I hope we can do better for future contributions from you. Thanks!