Make paginator strings translatable #1038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All but the pt_BR translations are based on the translations available on the KnpPaginatorBundle. That bundle doesn't have any string equivalent to "current", so this is why this translation is missing in all languages, except pt_BR and en.
davialexandre
force-pushed
the
translatable-paginator-strings
branch
from
cbdbd18 to
5469477
Compare
|
Thank you @davialexandre. |
javiereguiluz
added a commit
that referenced
this pull request
Oct 29, 2019
This PR was merged into the master branch. Discussion ---------- Make paginator strings translatable All but the `pt_BR` translations are based on the translations available on the KnpPaginatorBundle. That bundle doesn't have any string equivalent to "current", so this is why this translation is missing in all languages, except for `pt_BR` and `en`. Commits ------- 5469477 Make paginator strings translatable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All but the
pt_BRtranslations are based on the translations available on the KnpPaginatorBundle. That bundle doesn't have any string equivalent to "current", so this is why this translation is missing in all languages, except forpt_BRanden.