-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Remove "symfony/polyfill-php72" from the dependencies #1066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@rosier, You should commit the BTW, it's better to remove packages using $ composer remove symfony/polyfill-php72 |
if you really want to ensure it is not there, you might need to add it in the |
@voronkovich I used the web interface of GitHub and forgot the composer.lock. I have amended the commit. @stof I will make a new PR for the replace section later to include the other unneeded polyfills too |
Tests fail on php-cs-fixer, but I think that is already addressed in #1063 |
This PR was squashed before being merged into the master branch (closes #1067). Discussion ---------- Validate composer files while TravisCI build This check prevents us from having an out of sync composer's lock-file (For example, when someone forgot to commit composer.lock file: #1066). Commits ------- 8438677 Validate composer files while TravisCI build
@rosier thanks for this contribution! However, I'm afraid that after merging other PRs, this PR now has some conflicts. Could you please fix it again so we can merge it? Thanks. |
I resolved the conflicts. The tests fail on a segmentation fault of ./bin/phpunit |
… dependencies PHP version 7.2+ is already required by Symfony 5
@stof I have now add a |
Thanks for the rebasing and thanks a lot for your contribution! |
…sier) This PR was merged into the master branch. Discussion ---------- Remove "symfony/polyfill-php72" from the dependencies PHP version 7.2+ is already required by Symfony 5 Commits ------- 701da6d Remove "symfony/polyfill-php70" and "symfony/polyfill-php72" from the dependencies
This PR was squashed before being merged into the master branch (closes #1067). Discussion ---------- Validate composer files while TravisCI build This check prevents us from having an out of sync composer's lock-file (For example, when someone forgot to commit composer.lock file: symfony/demo#1066). Commits ------- 8438677 Validate composer files while TravisCI build
This PR was squashed before being merged into the master branch (closes #1067). Discussion ---------- Validate composer files while TravisCI build This check prevents us from having an out of sync composer's lock-file (For example, when someone forgot to commit composer.lock file: symfony/demo#1066). Commits ------- 8438677 Validate composer files while TravisCI build
This PR was squashed before being merged into the master branch (closes #1067). Discussion ---------- Validate composer files while TravisCI build This check prevents us from having an out of sync composer's lock-file (For example, when someone forgot to commit composer.lock file: symfony/demo#1066). Commits ------- 8438677 Validate composer files while TravisCI build
PHP version 7.2+ is already required by Symfony 5