Skip to content

Conversation

rosier
Copy link
Contributor

@rosier rosier commented Jan 12, 2020

PHP version 7.2+ is already required by Symfony 5

@voronkovich
Copy link
Contributor

@rosier, You should commit the composer.lock too. If you changed the composer.json manually, use composer update --lock command to update lock-file (See https://getcomposer.org/doc/03-cli.md#update-u).

BTW, it's better to remove packages using composer remove command:

$ composer remove symfony/polyfill-php72

@stof
Copy link
Member

stof commented Jan 13, 2020

if you really want to ensure it is not there, you might need to add it in the replace section as well, as some other packages might depend on it.

@rosier
Copy link
Contributor Author

rosier commented Jan 14, 2020

@voronkovich I used the web interface of GitHub and forgot the composer.lock. I have amended the commit.

@stof I will make a new PR for the replace section later to include the other unneeded polyfills too

@rosier
Copy link
Contributor Author

rosier commented Jan 14, 2020

Tests fail on php-cs-fixer, but I think that is already addressed in #1063

javiereguiluz added a commit that referenced this pull request Jan 15, 2020
This PR was squashed before being merged into the master branch (closes #1067).

Discussion
----------

Validate composer files while TravisCI build

This check prevents us from having an out of sync composer's lock-file (For example, when someone forgot to commit composer.lock file: #1066).

Commits
-------

8438677 Validate composer files while TravisCI build
@javiereguiluz
Copy link
Member

@rosier thanks for this contribution! However, I'm afraid that after merging other PRs, this PR now has some conflicts. Could you please fix it again so we can merge it? Thanks.

@rosier
Copy link
Contributor Author

rosier commented Jan 15, 2020

I resolved the conflicts. The tests fail on a segmentation fault of ./bin/phpunit

… dependencies

PHP version 7.2+ is already required by Symfony 5
@rosier
Copy link
Contributor Author

rosier commented Jan 15, 2020

@stof I have now add a replace section as well

@javiereguiluz
Copy link
Member

Thanks for the rebasing and thanks a lot for your contribution!

javiereguiluz added a commit that referenced this pull request Jan 16, 2020
…sier)

This PR was merged into the master branch.

Discussion
----------

Remove "symfony/polyfill-php72" from the dependencies

PHP version 7.2+ is already required by Symfony 5

Commits
-------

701da6d Remove "symfony/polyfill-php70" and "symfony/polyfill-php72" from the dependencies
@javiereguiluz javiereguiluz merged commit 701da6d into symfony:master Jan 16, 2020
@rosier rosier deleted the patch-1 branch January 21, 2020 22:09
sayjun0505 added a commit to sayjun0505/sym_proj that referenced this pull request Apr 16, 2023
This PR was squashed before being merged into the master branch (closes #1067).

Discussion
----------

Validate composer files while TravisCI build

This check prevents us from having an out of sync composer's lock-file (For example, when someone forgot to commit composer.lock file: symfony/demo#1066).

Commits
-------

8438677 Validate composer files while TravisCI build
spider-yamet added a commit to spider-yamet/sym_proj that referenced this pull request Apr 16, 2023
This PR was squashed before being merged into the master branch (closes #1067).

Discussion
----------

Validate composer files while TravisCI build

This check prevents us from having an out of sync composer's lock-file (For example, when someone forgot to commit composer.lock file: symfony/demo#1066).

Commits
-------

8438677 Validate composer files while TravisCI build
frederickboyd pushed a commit to frederickboyd/frederickboyd that referenced this pull request May 25, 2025
This PR was squashed before being merged into the master branch (closes #1067).

Discussion
----------

Validate composer files while TravisCI build

This check prevents us from having an out of sync composer's lock-file (For example, when someone forgot to commit composer.lock file: symfony/demo#1066).

Commits
-------

8438677 Validate composer files while TravisCI build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants