Require symfony/apache-pack package #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Victor! You explained it well: in other circumstances we wouldn't add this package ... but this app is very special and people have already told us several times "we need this". So, let's add it. Thanks. |
javiereguiluz
added a commit
that referenced
this pull request
Jan 22, 2020
This PR was merged into the master branch. Discussion ---------- Require symfony/apache-pack package What about to add `symfony/apache-pack` to this project? We have had a few related issues about missing it: #1069, #1005, #711 . Basically, it's a really small package that just adds `.htaccess` file into public/ dir and that's it. It would help Apache users and does not do any harm to others I think, so why not have it out of the box? Commits ------- 9a2dad5 Require symfony/apache-pack package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What about to add
symfony/apache-packto this project? We have had a few related issues about missing it: #1069, #1005, #711 . Basically, it's a really small package that just adds.htaccessfile into public/ dir and that's it. It would help Apache users and does not do any harm to others I think, so why not have it out of the box?