Use locked PHPUnit from dependencies #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -31,7 +31,8 @@ | |||
| "white-october/pagerfanta-bundle" : "^1.0" | |||
| }, | |||
| "require-dev": { | |||
| "sensio/generator-bundle" : "~3.0", | |||
| "phpunit/phpunit" : "^4.8 | ^5.0", | |||
There was a problem hiding this comment.
the Composer recommendation is to use || for the OR operator rather than |, because it is the operator used by other semver-based dependency managers
|
@bocharsky-bw it's merged now. Thanks for proposing this improvement. |
javiereguiluz
added a commit
that referenced
this pull request
Aug 31, 2016
…ereguiluz) This PR was merged into the master branch. Discussion ---------- Use locked PHPUnit from dependencies This finishes and rebases #365. Commits ------- 41fad4b Fixed binaries path in AppVeyor script 46ac33e Moved binaries back to vendor/bin/ 189eec1 Use the recommended OR operator 239b6b8 Allow to install newer PHPUnit versions 381732d Use locked PHPUnit from dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes and rebases #365.