Use .xlf extension instead of .xliff one for translations #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bocharsky-bw it totally makes sense! Thanks for improving this. |
javiereguiluz
added a commit
that referenced
this pull request
Oct 7, 2016
…(bocharsky-bw) This PR was merged into the master branch. Discussion ---------- Use .xlf extension instead of .xliff one for translations Symfony uses `.xlf` extension in its [XliffFileDumper](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Translation/Dumper/XliffFileDumper.php#L53-L56) instead of `.xliff` which currently uses by Symfony Demo. BTW, the `.xlf` is correct filename extension according to the [wiki](https://en.wikipedia.org/wiki/XLIFF) page about XLIFF format. What about to change translations' extension for consistency? Commits ------- b760de8 Use .xlf extension instead of .xliff one for translations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony uses
.xlfextension in its XliffFileDumper instead of.xliffwhich currently uses by Symfony Demo. BTW, the.xlfis correct filename extension according to the wiki page about XLIFF format.What about to change translations' extension for consistency?