Remove obsolete code #390
Merged
Remove obsolete code #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that Doctrine DBAL 2.5.5 is out, I think we can remove this "hack". Also because the config value is different from the one recommended and commented in the main config, which might confuse people.
|
👍 |
|
Thanks Fabien. |
javiereguiluz
added a commit
that referenced
this pull request
Oct 17, 2016
This PR was merged into the master branch. Discussion ---------- Remove obsolete code Now that Doctrine DBAL 2.5.5 is out, I think we can remove this "hack". Also because the config value is different from the one recommended and commented in the main config, which might confuse people. Commits ------- efb8582 Remove obsolete code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Doctrine DBAL 2.5.5 is out, I think we can remove this "hack". Also because the config value is different from the one recommended and commented in the main config, which might confuse people.