Display missing "about" section in admin blog show page #430
Conversation
| @@ -46,5 +46,7 @@ | |||
| }, with_context = false) }} | |||
| </div> | |||
|
|
|||
| {{ parent() }} | |||
There was a problem hiding this comment.
Probably, the original idea was to show that we can override content of parent block, but I can be wrong here...
There was a problem hiding this comment.
I don't remember ... but the rest of admin/* templates include this parent() ... so this is probably a bug.
| @@ -46,5 +46,7 @@ | |||
| }, with_context = false) }} | |||
| </div> | |||
|
|
|||
| {{ parent() }} | |||
There was a problem hiding this comment.
I don't remember ... but the rest of admin/* templates include this parent() ... so this is probably a bug.
| @@ -34,8 +34,7 @@ | |||
| */ | |||
| class LoadFixtures implements FixtureInterface, ContainerAwareInterface | |||
There was a problem hiding this comment.
ContainerAwareInterface should be removed here too
There was a problem hiding this comment.
no. The class is still container aware (but it uses the trait to implement it instead of doing it explicitly)
There was a problem hiding this comment.
I'm sorry! I'm not very familiar with traits.
|
Thanks @yceruto. |
Also I've added in this PR some minor simplifications ;)