Skip to content

Cleanup and comments about Tags feature implementation #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 7, 2017
Merged

Cleanup and comments about Tags feature implementation #450

merged 5 commits into from
Feb 7, 2017

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented Feb 6, 2017 •
edited
Loading

  • Removed unused old isAuthor() method from Post
  • Removed useless PHPDoc
  • Add code comments about Tags feature implementation
  • Removed setByReference option which is unnecessary now.

@yceruto
Copy link
Member Author

yceruto commented Feb 7, 2017

Thanks to new instance of ArrayCollection into CollectionToArrayTransformer now we can remove the setByReference(false) option, so the form data mapper should call setter always.

javiereguiluz
javiereguiluz approved these changes Feb 7, 2017
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@javiereguiluz
Copy link
Member

@yceruto thanks for these nice improvements!

@javiereguiluz javiereguiluz merged commit 6147bbd into symfony:master Feb 7, 2017
javiereguiluz added a commit that referenced this pull request Feb 7, 2017
@javiereguiluz
minor #450 Cleanup and comments about Tags feature implementation (yc…
e533bd0 
…eruto, javiereguiluz)

This PR was merged into the master branch.

Discussion
----------

Cleanup and comments about Tags feature implementation

* Removed unused old `isAuthor()` method from `Post`
* Removed useless PHPDoc
* Add code comments about Tags feature implementation
* Removed setByReference option which is unnecessary now.

Commits
-------

6147bbd Updated the last help note
a62876f Updated some help notes
4d71179 Updated a help note
a574d24 Remove byReference option which is unnecessary now
ba34c26 Cleanup and comments about Tags feature implementation
@yceruto yceruto deleted the cleanup-and-comments branch February 7, 2017 12:15
@yceruto
Copy link
Member Author

yceruto commented Feb 7, 2017

@javiereguiluz thanks to you for improving it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
FINISHED
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yceruto @javiereguiluz