Improve fixture generation #470
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
javiereguiluz
commented
Feb 14, 2017
javiereguiluz
commented
- Add at least 1 tag to every blog post, to make the design more consistent
- Don't cut out the phrases of the post summary.
stof
reviewed
Feb 14, 2017
| @@ -91,11 +91,7 @@ public function getDependencies() | |||
|
|
|||
| private function addRandomTags(Post $post) | |||
| { | |||
| if (0 === $count = mt_rand(0, 3)) { | |||
There was a problem hiding this comment.
this means we don't have any post without tags in the fixtures. Is it expected ? Tagging posts is optional
The validation of posts does not require having at least 1 tag. So if the design does not support such case, it means that there is a bug in the code, not that fixtures should be changed |
|
I've changed the fixtures again: posts can have 0 tags ... but the first post now always has 2 tags, to make the application look better. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.