Require php-intl instead of crashing on IntlTimeZone #895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 7.2 on Ubuntu does not have php7.2-intl installed by default.
With composer install there are no check for intl extension
and first page shows misleading error:
Attempted to load class "IntlTimeZone" from the global namespace.
Did you forget a "use" statement?
It is better to show warning during composer install
(or composer create-project):
Your requirements could not be resolved to an installable set of packages.
Problem 1
- The requested PHP extension ext-intl * is missing from your system. Install or enable PHP's intl extension.
So it would be easier to google, that problem could be solved with:
sudo apt-get install php7.2-intl
aurelijusb
added a commit
to nfqakademija/docker
that referenced
this pull request
Nov 12, 2018
Because SymfonyDemo app requires it. See symfony/demo#895
aurelijusb
added a commit
to nfqakademija/docker
that referenced
this pull request
Nov 12, 2018
Because SymfonyDemo app requires it. Added icu and g++ libraries, because those were needed for intl package to be installed via docker-php-ext-install See symfony/demo#895
|
@javiereguiluz as discussed in the issue, that might not be the preferred way there. |
javiereguiluz
added a commit
that referenced
this pull request
Nov 15, 2018
This PR was squashed before being merged into the master branch (closes #890). Discussion ---------- Sufix translations files with +intl-icu ~~Also added intl extension to composer require because when I was testing on my machine, this extension was missing.~~ Reverting intl extension require in favor of #895 Maybe we could require [`polyfill-intl-normalizer`](https://github.com/symfony/polyfill-intl-normalizer) instead of the extension. Commits ------- 888897b Sufix translations files with +intl-icu
|
@stof I'm afraid I don't understand your comment. Do you like the change proposed in this pull request? |
|
@javiereguiluz in the issue, I suggested that this issue should be fixed in Twig-extensions instead, to keep it compatible with the polyfill, instead of requiring the extension in the demo. |
|
Does this issue still exist for the latest version of the project on Ubuntu? |
|
Seems to be solved 🙂 Thanks. Closing.
|
|
Thank you for reporting it! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 7.2 on Ubuntu does not have
php7.2-intlinstalled by default.With
composer installthere are no check forintlextensionand first page shows misleading error:
It is better to show warning during
composer install(or composer create-project):
So it would be easier to google, that the original problem could be solved with: