Fix translations files with ICU message formater #908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ker0x
commented
Dec 4, 2018
| @@ -20,15 +20,15 @@ | |||
| </trans-unit> | |||
| <trans-unit id="http_error.name"> | |||
| <source>http_error.name</source> | |||
| <target>Грешка %status_code%</target> | |||
| <target>Грешка {status_code, number}</target> | |||
There was a problem hiding this comment.
I'm not sure if the type is needed here! I added it by principe but feedback will be appreciated
| @@ -80,7 +80,7 @@ | |||
| </trans-unit> | |||
| <trans-unit id="title.edit_post"> | |||
| <source>title.edit_post</source> | |||
| <target>Редактиране на публикация #%id%</target> | |||
| <target>Редактиране на публикация #{id, number}</target> | |||
There was a problem hiding this comment.
Here too, not sure if needed !
|
Thanks for fixing this bug Romain. |
javiereguiluz
added a commit
that referenced
this pull request
Dec 4, 2018
This PR was merged into the master branch. Discussion ---------- Fix translations files with ICU message formater As pointed by @stof in #890, translations files does no longer take in account variables because of the `+intl-icu` suffix in translation files. This PR fix that! Commits ------- c29e1dd Fix translations files with ICU message formater
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed by @stof in #890, translations files does no longer take in account variables because of the
+intl-icusuffix in translation files. This PR fix that!