Fix getting template source and update deps #968
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
reviewed
Apr 26, 2019
src/Twig/SourceCodeExtension.php
Outdated
| { | ||
| if (!$template instanceof TemplateWrapper && !$template instanceof Template) { | ||
| throw new \Exception(sprintf( |
There was a problem hiding this comment.
I'm not sure this exception is needed... this function is private/local and $twig->resolveTemplate($template) only returns TemplateWrapper or Template.
I'd suggest adding a PHPDoc block instead.
There was a problem hiding this comment.
I'm fine with PHPDoc, just was coding defensively... Let's wait for more feedback then
There was a problem hiding this comment.
I agree with Yonel on this one.
There was a problem hiding this comment.
OK, it's simpler now 👍
|
Shouldn't we also update this line? Line 33 in 4bc69f6 |
Hm, don't think we needed. Updated to what? |
yceruto
approved these changes
Apr 29, 2019
|
Thank you Victor; it's merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #967 and some vulnerability issues in deps