[ci] implement phpstan for static analysis of the codebase #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrushlow
added
Status: Needs Work
This was referenced Apr 2, 2024
jrushlow
commented
Apr 2, 2024
This was referenced Apr 2, 2024
jrushlow
force-pushed
the
minor/phpstan
branch
2 times, most recently
from
95cef87
to
55e2031
Compare
This was referenced Apr 5, 2024
jrushlow
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll start with the scope below and slowly open it up as the code base is updated to the desired PHPStan level.
Scope
src/Makertests/Commandtests/Dockertests/MakerOptional Maker Dependencies -
tools/phpstan/includesIn our root
composer.json, we don'trequire --devpackages that are not specifically needed for MakerBundle to function. e.g.api-platform. But we do still need those packages for phpstan. for now, thecomposer.jsonin theincludesdir will satisfy that need and gives MakerBundle dev's the added benefit of code completion in the IDE.We currently do not require those "maker specific" packages in our root
composer.jsonbecause it would have adverse side effects in some of our tests. I think in MakerBundle 2.x and/or #1466 - we'll change how we manage dependencies.