Checking on reserved keywords for class name validity.

[SerkanYildiz]

Validator should also check if the given class name is a reserved keyword or not.
However we have to come up with a better exception message, since this one does not reflect the error. Any suggestion?

Thanks for your help @weaverryan during #SymfonyConHackDay2018

Fixes #305

[sadikoff]

'int', 'float', 'bool', 'string', 'true', 'false', 'null', 'void',
'iterable', 'object',

This words are allowed to use in Namespace, anyway it will be very strange to use it :-)

[sadikoff]

Maybe will be better not to change this check, but add a new check with new error message, to show the user what is wrong with classname?

[SerkanYildiz]

@sadikoff Thanks for your review! Wdyt about my current fix?

[sadikoff]

@SerkanYildiz It's great that you have done it so fast, but I was talking about something else. I suggested not to split namespace and class validator, but leave old validation in place and add new one which will validate reserved words
ex:

foreach ($pieces as $piece) {
    if (!preg_match('/^[a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*$/', $piece)) {
        $errorMessage = $errorMessage ?: sprintf('"%s" is not valid as a PHP class name (it must start with a letter or underscore, followed by any number of letters, numbers, or underscores)', $className);
        throw new RuntimeCommandException($errorMessage);
    }
    if (Str::isPhpReservedWord($piece)) {
        throw new RuntimeCommandException(sprintf('"%s" is a reserved keyword and thus cannot be used as class name in PHP.', $className));
    }
}

[weaverryan]

Yea... I think I agree. So remove Str::isValidPhpClassName() and just move that logic into Validator:: validateClassName() as @sadikoff.

But otherwise, this is awesome! I like tightening things up :)

[weaverryan]

Ping @SerkanYildiz! I think we need just one more small change. Does my description above make sense?

Cheers!

[SerkanYildiz]

Pong @weaverryan! Will fix this today, thanks for helping!

[SerkanYildiz]

@weaverryan Pushed the requested changes. Does it look good now?

[SerkanYildiz]

@weaverryan Tests are failing due another error. Should I do something?

[weaverryan]

Thank you @SerkanYildiz!