Skip to content

Run CI with various versions of Symfony #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
Merged

Run CI with various versions of Symfony #518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,21 +28,33 @@ jobs:
strategy:
fail-fast: false
matrix:
php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3' ]
monolog: [ '1.*', '2.*' ]
php: [ '8.1', '8.2', '8.3', '8.4' ]
monolog: [ '2.*' ]
symfony: [ '6.4.*' ]
include:
- php: '7.2'
symfony: '5.4.*'
monolog: '1.*'
- php: '7.4'
deps: lowest
symfony: '5.4.*'
deprecations: max[self]=0
- php: '8.1'
monolog: '3.*'
symfony: '6.4.*'
- php: '8.2'
monolog: '3.*'
symfony: '7.3.*'
- php: '8.3'
monolog: '3.*'
symfony: '7.3.*'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wrong approach to solve this problem IMO, as it means that we have to remember to update the CI of monolog-bundle every 6 months when Symfony releases new versions, otherwise we don't test latest versions (while our requirements allow them).

A cleaner solution is to have most job run with original composer requirements (so no SYMFONY_REQUIRE), and to add extra jobs forcing a Symfony version for the supported LTS versions (which need maintenance only every 2 years when LTS versions change).
Non-LTS versions will be installed by the normal jobs as Composer installs the latest compatible version

See https://github.com/FriendsOfSymfony/FOSUserBundle/blob/master/.github/workflows/ci.yaml for an example setup (where I'm not skipping the definition of the env variable when matrix.symfony is false but I'm skipping the installation of Flex, which consumes it, producing an equivalent result)

- php: '8.4'
deps: highest
monolog: '3.*'
symfony: '7.4.*'

env:
SYMFONY_REQUIRE: ${{ matrix.symfony }}

steps:
- name: Checkout
Expand Down