Skip to content

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Sep 24, 2025

Q A
Branch? 3.x
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

Ensure the bundle is compatible with all the supported Symfony versions.

@GromNaN GromNaN force-pushed the ci-symfony-versions branch 3 times, most recently from 177ea30 to 78ee9ed Compare September 24, 2025 11:32
@GromNaN GromNaN force-pushed the ci-symfony-versions branch from 78ee9ed to f9e73bc Compare September 24, 2025 11:35
@GromNaN GromNaN requested a review from HypeMC September 24, 2025 11:40
@GromNaN GromNaN merged commit c64ef75 into symfony:3.x Sep 24, 2025
11 checks passed
@GromNaN GromNaN deleted the ci-symfony-versions branch September 24, 2025 11:50
symfony: '7.3.*'
- php: '8.3'
monolog: '3.*'
symfony: '7.3.*'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wrong approach to solve this problem IMO, as it means that we have to remember to update the CI of monolog-bundle every 6 months when Symfony releases new versions, otherwise we don't test latest versions (while our requirements allow them).

A cleaner solution is to have most job run with original composer requirements (so no SYMFONY_REQUIRE), and to add extra jobs forcing a Symfony version for the supported LTS versions (which need maintenance only every 2 years when LTS versions change).
Non-LTS versions will be installed by the normal jobs as Composer installs the latest compatible version

See https://github.com/FriendsOfSymfony/FOSUserBundle/blob/master/.github/workflows/ci.yaml for an example setup (where I'm not skipping the definition of the env variable when matrix.symfony is false but I'm skipping the installation of Flex, which consumes it, producing an equivalent result)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants