Remove legacy code paths #519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HypeMC
commented
Sep 24, 2025
| $loader = new PhpFileLoader($container, new FileLocator(__DIR__.'/../../config')); | ||
| $loader->load('monolog.php'); | ||
|
|
||
| if (!class_exists(DebugLoggerConfigurator::class)) { |
There was a problem hiding this comment.
Min Symfony always has this.
There was a problem hiding this comment.
This was added in Symfony 6.4 with symfony/symfony#51284. I wonder if we should think about bumping the minimum required version of Symfony components in the 3.x branch to 6.4 and do some of the clean up work there already.
There was a problem hiding this comment.
I'm ok with the idea, if needed I'll open a PR that bumps Symfony in 3.x.
HypeMC
commented
Sep 24, 2025
Comment on lines
+89
to
+92
| $container->registerForAutoconfiguration(ProcessorInterface::class) | ||
| ->addTag('monolog.processor'); | ||
| $container->registerForAutoconfiguration(ResettableInterface::class) | ||
| ->addTag('kernel.reset', ['method' => 'reset']); |
There was a problem hiding this comment.
Min Monolog always has these interfaces.
HypeMC
commented
Sep 24, 2025
|
|
||
| if (!empty($processorOptions)) { | ||
| if (!$hasConstructorArguments) { | ||
| throw new \RuntimeException('Monolog 1.26 or higher is required for the "date_format" and "remove_used_context_fields" options to be used.'); |
There was a problem hiding this comment.
Min Monolog always has PsrLogMessageProcessor with these args.
derrabus
approved these changes
Sep 24, 2025
GromNaN
approved these changes
Sep 24, 2025
|
Thank you @HypeMC. |
Merged
GromNaN
added a commit
that referenced
this pull request
Sep 25, 2025
This PR was merged into the 3.x branch. Discussion ---------- Require Symfony 6.4 and PHP 8.1 | Q | A | ------------- | --- | Branch? | 3.x | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Fix #519 (comment) | License | MIT Bumping Symfony to 6.4 also means bumping PHP to 8.1, as that's the min version supported by that Symfony version. Commits ------- d576ff5 Require Symfony 6.4 and PHP 8.1
Merged
GromNaN
added a commit
that referenced
this pull request
Sep 26, 2025
This PR was merged into the 4.x branch. Discussion ---------- Removed redundant check | Q | A | ------------- | --- | Branch? | 4.x | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Missed this one in #519, the `SwitchUserTokenProcessor` class is always available ([was added in Symfony 5.2](symfony/symfony#37704), min supported is 7.3). Commits ------- 00b7149 Removed redundant check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some legacy code paths/conditions for older versions of Symfony, Monolog & PHP.