Test to show FieldEntry serialization bug and a fix proposal #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change serialize input format - to avoid segmentation fault on php 5.5.26 os x - to make it exactly the same format as used internally by Acl::serialize
- fix field entry unserialize in case when few FieldEntry instances has save SecurityIdentityInterface instance
|
Updated PR with a fix proposal |
ishakuta
changed the title
|
Hi @ishakuta! Sorry for the embarrassing long silence here. We modernized some parts of this library last week and I can't replicate this bug anymore. Either it was fixed in the currently minimal PHP version, or it was fixed when changing to the better PHP serialization (ref #90). Either way, I've extracted the test from this PR (ref #94) to make sure this bug will not occur anymore. Thanks for creating a reproducing test case! |
wouterj
added a commit
that referenced
this pull request
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to @alipek:
"This commit show problem with serialize Acl with many FieldEntry objects contains same sid."
symfony/symfony#12873
and issue created in symfony repo symfony/symfony#12875 and closed cause of acl component was moved into separate repository.