Skip to content

Test to show FieldEntry serialization bug and a fix proposal #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Test to show FieldEntry serialization bug and a fix proposal #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ef9e9f
Test show FieldEntry serialization Bug
alipek Dec 5, 2014
3369f76
Test to show FieldEntry serialization Bug
ishakuta Oct 15, 2015
896b53d
FieldEntry serialize/unserialize
ishakuta Oct 16, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Domain/Entry.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,9 @@ public function serialize()
return serialize(array(
$this->mask,
$this->id,
$this->securityIdentity,
// clone due to the unserialize issue in php 5.4-5.6
// when Acl has few FieldEntry objects with the same SecurityIdentityInterface instance
clone $this->securityIdentity,
$this->strategy,
$this->auditFailure,
$this->auditSuccess,
Expand Down
34 changes: 34 additions & 0 deletions Tests/Domain/FieldEntryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,40 @@ public function testSerializeUnserialize()
$this->assertEquals($ace->isAuditFailure(), $uAce->isAuditFailure());
}

/**
* Test that two FieldEntry objects correctly serialized and unserialized
*/
public function testSerializeUnserializeMoreAceWithSameSecurityIdentity()
{
$sid = $this->getSid();

$aceFirst = $this->getAce(null, $sid);
$aceSecond = $this->getAce(null, $sid);

// as used in DoctrineAclCache::putInCache (line 142)
$serialized = serialize(
array( // Acl:serialize (line 260)
[ // classFieldAces
'fieldOne' => [$aceFirst],
'fieldTwo' => [$aceSecond],
]
)
);

$unserialized = unserialize($serialized);
$uAceFirst = $unserialized[0]['fieldOne'][0];
$uAceSecond = $unserialized[0]['fieldTwo'][0];

$this->assertInstanceOf(
'Symfony\Component\Security\Acl\Model\SecurityIdentityInterface',
$uAceFirst->getSecurityIdentity()
);
$this->assertInstanceOf(
'Symfony\Component\Security\Acl\Model\SecurityIdentityInterface',
$uAceSecond->getSecurityIdentity()
);
}

protected function getAce($acl = null, $sid = null)
{
if (null === $acl) {
Expand Down