Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove YAML mapping examples #6752

Closed
xabbuh opened this Issue Jul 13, 2016 · 9 comments

Comments

Projects
None yet
5 participants
@xabbuh
Copy link
Member

xabbuh commented Jul 13, 2016

Given that Doctrine will remove support for defining ORM metadata in YAML format (see doctrine/orm#5932), we should probably already remove references to this format.

@ogizanagi

This comment has been minimized.

Copy link
Member

ogizanagi commented Jul 13, 2016

@xabbuh : Sorry for the unrelated comment, but do you know if there is any related issue or comment explaining why Doctrine will not support anymore defining ORM metadata in YAML format ?

(Appart from https://twitter.com/lcobucci/status/752968139705647104)

@xabbuh

This comment has been minimized.

Copy link
Member Author

xabbuh commented Jul 13, 2016

@ogizanagi Somewhere I read a comment by @Ocramius that the code for it was too fragile IIRC. Maybe he can give you some more insights.

@Ocramius

This comment has been minimized.

Copy link
Contributor

Ocramius commented Jul 13, 2016

The change will affect ORM 3.0: do you really want to raise it here already? I don't think that you should worry about it yet.

@xabbuh

This comment has been minimized.

Copy link
Member Author

xabbuh commented Jul 13, 2016

@Ocramius Will the XML and annotation mapping formats change in 3.0? If not, it imo is a good idea not to advocate to use YAML anymore to ease migrating to Doctrine 3.

@Ocramius

This comment has been minimized.

Copy link
Contributor

Ocramius commented Jul 13, 2016

Not sure yet.
On 13 Jul 2016 18:51, "Christian Flothmann" notifications@github.com
wrote:

@Ocramius https://github.com/Ocramius Will the XML and annotation
mapping formats change in 3.0? If not, it imo is a good idea not to
advocate to use YAML anymore to ease migrating to Doctrine 3.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#6752 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAJakOP2UpyNygk3Rb548-6ly8jRRo-tks5qVRd_gaJpZM4JLh8j
.

@robfrawley

This comment has been minimized.

Copy link
Contributor

robfrawley commented Jul 18, 2016

@Ocramius Where can I find discussions on the removal of YML in D3?! (The post @ doctrine/orm#5932 has more thumbs down than thumbs up at this point...)

@Ocramius

This comment has been minimized.

Copy link
Contributor

Ocramius commented Jul 18, 2016

@robfrawley we are currently working on rewriting the entire metadata-related internals of the ORM, and the Yaml driver was just long-due removal. We just needed to finally have a practical excuse (3.x + refactoring) to do so, and we did.

The Yaml driver has always been lagging back (bugs, support, docs, etc) due to the squishy format of it (no type checking, no static analysis, no autocompletion), so you'll likely see it implemented by third parties than by Doctrine itself in 3.x.

@robfrawley

This comment has been minimized.

Copy link
Contributor

robfrawley commented Jul 20, 2016

@Ocramius Thanks for the detailed response. Makes sense; still sad from an end-user perspective but I understand the development need to remove areas that pose difficulties where the return is far less than the investment. Again, appreciate the info.

@javiereguiluz

This comment has been minimized.

Copy link
Member

javiereguiluz commented Mar 6, 2018

Closed in favor of the meta-issue #9401.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.