Skip to content

[Validator] Added missing examples in IdenticalTo constraint #10830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2019

Conversation

xElysioN
Copy link
Contributor

@xElysioN xElysioN commented Jan 2, 2019

Hi,
This fix #10829 (Missing YAML, XML and PHP example in Basic Usage)

And add missing space for age in Basic Usage.

Link of changes : https://pr-10830-trovf4q-nq3xa5jtywvyc.eu.s5y.io/reference/constraints/IdenticalTo.html

Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@HeahDude HeahDude changed the title fix #10829: add missing examples in IdenticalTo constraint [Validator] Added missing examples in IdenticalTo constraint Jan 3, 2019
@javiereguiluz
Copy link
Member

@xElysioN this is a great first contribution to Symfony Docs. Thank you and congrats!

@javiereguiluz javiereguiluz merged commit ad78e1b into symfony:3.4 Jan 3, 2019
javiereguiluz added a commit that referenced this pull request Jan 3, 2019
…aint (xElysioN)

This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] Added missing examples in IdenticalTo constraint

Hi,
This fix #10829 (Missing YAML, XML and PHP example in Basic Usage)

And add missing space for ``age`` in Basic Usage.

Link of changes : https://pr-10830-trovf4q-nq3xa5jtywvyc.eu.s5y.io/reference/constraints/IdenticalTo.html

Commits
-------

ad78e1b fix #10829: add missing examples in IdenticalTo constraint
@xElysioN xElysioN deleted the fix_10829 branch January 3, 2019 11:42
nikophil pushed a commit to nikophil/symfony-docs that referenced this pull request Jan 3, 2019
… constraint (xElysioN)

This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] Added missing examples in IdenticalTo constraint

Hi,
This fix symfony#10829 (Missing YAML, XML and PHP example in Basic Usage)

And add missing space for ``age`` in Basic Usage.

Link of changes : https://pr-10830-trovf4q-nq3xa5jtywvyc.eu.s5y.io/reference/constraints/IdenticalTo.html

Commits
-------

ad78e1b fix symfony#10829: add missing examples in IdenticalTo constraint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants