Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document changes in the deprecation error handler #11323

Closed
wants to merge 5 commits into from

Conversation

llaakkkk
Copy link

@llaakkkk llaakkkk commented Apr 6, 2019

components/phpunit_bridge.rst Outdated Show resolved Hide resolved
components/phpunit_bridge.rst Outdated Show resolved Hide resolved
components/phpunit_bridge.rst Show resolved Hide resolved
@OskarStark OskarStark added Waiting Code Merge Docs for features pending to be merged ⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming labels Apr 6, 2019
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻💥

Copy link
Contributor

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! My PR is finally merged! 🎉 Here is a review reflecting the latest changes.

bundles/best_practices.rst Outdated Show resolved Hide resolved
bundles/best_practices.rst Outdated Show resolved Hide resolved
components/phpunit_bridge.rst Outdated Show resolved Hide resolved
components/phpunit_bridge.rst Outdated Show resolved Hide resolved
components/phpunit_bridge.rst Show resolved Hide resolved
components/phpunit_bridge.rst Outdated Show resolved Hide resolved
components/phpunit_bridge.rst Outdated Show resolved Hide resolved
components/phpunit_bridge.rst Outdated Show resolved Hide resolved
components/phpunit_bridge.rst Outdated Show resolved Hide resolved
components/phpunit_bridge.rst Outdated Show resolved Hide resolved
@javiereguiluz javiereguiluz removed the Waiting Code Merge Docs for features pending to be merged label Apr 24, 2019
Copy link
Contributor

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

components/phpunit_bridge.rst Outdated Show resolved Hide resolved
components/phpunit_bridge.rst Show resolved Hide resolved
components/phpunit_bridge.rst Outdated Show resolved Hide resolved
components/phpunit_bridge.rst Outdated Show resolved Hide resolved
setup/upgrade_major.rst Outdated Show resolved Hide resolved
setup/upgrade_major.rst Outdated Show resolved Hide resolved
@javiereguiluz
Copy link
Member

javiereguiluz commented May 31, 2019

@llaakkkk thanks a lot for this contribution! I'm happy to finally have it merged in Symfony Docs. Cheers!

Note: GitHub displays this pull request as closed instead of merged ... that's because we changed the branch while merging (to merge it in 4.3 instead of master). But don't worry, it's merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming PHPUnitBridge Status: Reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants