Skip to content

Conversation

dbrumann
Copy link
Contributor

@dbrumann dbrumann commented Apr 6, 2019

Adds both a short description for existing processors as well as a note for the newly added TokenProcessor added in 3.4. I tried not to interfere with #10244 as this introduces documentation for more processors added in 4.3, so that PR hopefully can build on this one.

Replaces #8156

EUFOSSA

* :class:`Symfony\\Bridge\\Monolog\\Processor\\WebProcessor` overrides data from the request using the data inside Symfony's request object.

.. versionadded:: 3.4
The :class:``Symfony\\Bridge\\Monolog\\Processor\\TokenProcessor`` class was added in Symfony 3.4.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one tick should be use for the class

@OskarStark OskarStark added the ⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming label Apr 6, 2019
Adds both a short description for existing processors as well as a note
for the newly added TokenProcessor added in 3.4.

Replaces #8156
@@ -160,6 +160,16 @@ If you use several handlers, you can also register a processor at the
handler level or at the channel level instead of registering it globally
(see the following sections).

Symfony's MonologBridge provides processors that can be registered inside your application.

* :class:`Symfony\\Bridge\\Monolog\\Processor\\DebugProcessor` adds additional information useful for debugging like a timestamp or an error message to the record.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for mergers ... please wrap these lines to make them 80-char long. Thanks.

wouterj added a commit that referenced this pull request Apr 7, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

Adds documentation for monolog processors.

Adds both a short description for existing processors as well as a note for the newly added TokenProcessor added in 3.4. I tried not to interfere with #10244 as this introduces documentation for more processors added in 4.3, so that PR hopefully can build on this one.

Replaces #8156

EUFOSSA

Commits
-------

67f8c2c Adds documentation for monolog processors.
wouterj added a commit that referenced this pull request Apr 7, 2019
wouterj added a commit that referenced this pull request Apr 7, 2019
* 3.4:
  [#11328] Restructured into a definition list
  Fix a typo for the range of allowed attack complexity score values
  Addressed issues raised in (#10798)
  Add Doctrine ORM installation instructions.
  Adds documentation for monolog processors.
@wouterj wouterj merged commit 67f8c2c into symfony:3.4 Apr 7, 2019
wouterj added a commit that referenced this pull request Apr 7, 2019
* 4.2:
  [#11328] Restructured into a definition list
  Fix a typo for the range of allowed attack complexity score values
  Addressed issues raised in (#10798)
  Add Doctrine ORM installation instructions.
  Adds documentation for monolog processors.
@dbrumann dbrumann deleted the token_processors branch April 10, 2019 11:01
@wouterj wouterj mentioned this pull request Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming Status: Reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants