Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cache] Show how to configure redis provider #11364

Closed
wants to merge 5 commits into from

Conversation

Projects
None yet
5 participants
@Nyholm
Copy link
Member

commented Apr 8, 2019

This will properly fix #10989
Im not 100% confident on the xml configuration.

@nicolas-grekas is this a good description of the Provider?

@Nyholm Nyholm changed the base branch from master to 3.4 Apr 8, 2019

Show resolved Hide resolved cache.rst Outdated

@Nyholm Nyholm changed the title Show how to configure redis provider [Cache] Show how to configure redis provider Apr 8, 2019

@javiereguiluz

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

@xabbuh could you please double check the XML config? Thanks!

Nyholm added some commits Apr 8, 2019

@Nyholm Nyholm force-pushed the Nyholm:issue-10989 branch from d6ca04c to c7f8c01 Apr 9, 2019

@wouterj

wouterj approved these changes Apr 9, 2019

Copy link
Member

left a comment

XML looks good!

Looking at the XmlFileLoader, I it seems like key is used instead of name, but key defaults to name. So I think name looks more logical?

@javiereguiluz javiereguiluz added this to the 3.4 milestone Apr 9, 2019

@Nyholm

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2019

I did a quick search. Using "key" is standard on all other places in the docs

@Nyholm

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2019

Thank you for the reviews!

@javiereguiluz javiereguiluz added the Cache label Apr 9, 2019

javiereguiluz added a commit that referenced this pull request Apr 9, 2019

minor #11364 [Cache] Show how to configure redis provider (Nyholm)
This PR was squashed before being merged into the 3.4 branch (closes #11364).

Discussion
----------

[Cache] Show how to configure redis provider

This will properly fix #10989
Im not 100% confident on the xml configuration.

@nicolas-grekas is this a good description of the Provider?

Commits
-------

120a87e [Cache] Show how to configure redis provider
@javiereguiluz

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

Thanks Tobias (and reviewers) for another nice Cache contribution.

@Nyholm Nyholm deleted the Nyholm:issue-10989 branch Apr 9, 2019

@Nyholm Nyholm referenced this pull request Apr 9, 2019

Merged

[Cache] Syntax fix #11387

wouterj added a commit that referenced this pull request Apr 9, 2019

minor #11387 [Cache] Syntax fix (Nyholm)
This PR was merged into the 3.4 branch.

Discussion
----------

[Cache] Syntax fix

I made a typo in #11364

Commits
-------

f21b15a [Cache] Syntax fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.