Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show how to configure multiple redis servers #11388

Closed
wants to merge 6 commits into from

Conversation

Projects
None yet
6 participants
@Nyholm
Copy link
Member

commented Apr 9, 2019

This will fix #10573

Nyholm added some commits Apr 9, 2019

@Nyholm

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2019

I got even bolder with this PR. I removed the "user" stuff because it is invalid.

@Nyholm Nyholm changed the base branch from master to 4.2 Apr 9, 2019

@wouterj wouterj added the Cache label Apr 10, 2019

@Nyholm

This comment has been minimized.

Copy link
Member Author

commented Apr 10, 2019

@nicolas-grekas Could you verify the correctness of these docs?

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

We could need more details about the supported DSN for multi-hosts, but this is a very good start, thanks!

@javiereguiluz javiereguiluz added this to the 4.2 milestone Apr 11, 2019

@Nyholm

This comment has been minimized.

Copy link
Member Author

commented Apr 11, 2019

I've updated the PR to show some more examples with options.

I think it makes sense to show off how to configure the DSN since this will also be used with the framework bundle. If you are using the stand alone component you are more likely to pass an array of options as the second argument of createConnection.

);

.. versionadded:: 4.2

The option to define multiple servers in a single DSN was introduced in Symfony 4.2.

.. Note::

This comment has been minimized.

Copy link
@OskarStark

OskarStark Apr 11, 2019

Contributor

please note in lowercase

@Nyholm

This comment has been minimized.

Copy link
Member Author

commented Apr 11, 2019

Thank you for the reviews. I promise that I will make at least one PR without any syntax errors this month.

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

No worries, that's teamwork: round-robin errors and fixes ;)

@OskarStark

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

Yes if you write the docs we are happy to fix the syntax 💥✌🏻

@javiereguiluz

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

Thanks Tobias! Nice contribution ... and another issue fixed!

@Nyholm

This comment has been minimized.

Copy link
Member Author

commented Apr 12, 2019

Thank you for merging.

@Nyholm Nyholm deleted the Nyholm:4.2-redis-multiple-dns branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.