Skip to content

Show how to configure multiple redis servers #11388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Show how to configure multiple redis servers #11388

wants to merge 6 commits into from

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Apr 9, 2019

This will fix #10573

@Nyholm Nyholm mentioned this pull request Apr 9, 2019
Closed
wouterj
wouterj reviewed Apr 9, 2019
View reviewed changes
@Nyholm
Copy link
Member Author

Nyholm commented Apr 9, 2019

I got even bolder with this PR. I removed the "user" stuff because it is invalid.

@Nyholm Nyholm changed the base branch from master to 4.2 April 9, 2019 19:57
@wouterj wouterj added the Cache label Apr 10, 2019
@Nyholm
Copy link
Member Author

Nyholm commented Apr 10, 2019

@nicolas-grekas Could you verify the correctness of these docs?

@nicolas-grekas
Copy link
Member

We could need more details about the supported DSN for multi-hosts, but this is a very good start, thanks!

@javiereguiluz javiereguiluz added this to the 4.2 milestone Apr 11, 2019
@Nyholm
Copy link
Member Author

Nyholm commented Apr 11, 2019

I've updated the PR to show some more examples with options.

I think it makes sense to show off how to configure the DSN since this will also be used with the framework bundle. If you are using the stand alone component you are more likely to pass an array of options as the second argument of createConnection.

OskarStark
OskarStark reviewed Apr 11, 2019
View reviewed changes
components/cache/adapters/redis_adapter.rst Outdated
);

.. versionadded:: 4.2

The option to define multiple servers in a single DSN was introduced in Symfony 4.2.

.. Note::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please note in lowercase

@Nyholm
Copy link
Member Author

Nyholm commented Apr 11, 2019

Thank you for the reviews. I promise that I will make at least one PR without any syntax errors this month.

@nicolas-grekas
Copy link
Member

No worries, that's teamwork: round-robin errors and fixes ;)

@OskarStark
Copy link
Contributor

Yes if you write the docs we are happy to fix the syntax 💥✌🏻

@javiereguiluz
Copy link
Member

Thanks Tobias! Nice contribution ... and another issue fixed!

@Nyholm
Copy link
Member Author

Nyholm commented Apr 12, 2019

Thank you for merging.

@Nyholm Nyholm deleted the 4.2-redis-multiple-dns branch April 12, 2019 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj left review comments

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Cache Status: Reviewed
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
6 participants
@Nyholm @nicolas-grekas @OskarStark @javiereguiluz @wouterj @carsonbot