Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap aliases #11389

Merged
merged 1 commit into from Apr 10, 2019

Conversation

Projects
None yet
7 participants
@greg0ire
Copy link
Contributor

commented Apr 9, 2019

The comments above did not match. For the sake of explaining, it is
better to put the named aliases first.

Swap aliases
The comments above did not match. For the sake of explaining, it is
better to put the named aliases first.

@greg0ire greg0ire changed the base branch from master to 4.2 Apr 9, 2019

@wouterj

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

Thanks for your quick fixes! I assume the order doesn't matter in real life projects? (maybe that's usefull to add, but I'm not sure)

@wouterj wouterj merged commit 5052a37 into symfony:4.2 Apr 10, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
symfony SymfonyCloud: Environment deployed
Details

wouterj added a commit that referenced this pull request Apr 10, 2019

minor #11389 Swap aliases (greg0ire)
This PR was merged into the 4.2 branch.

Discussion
----------

Swap aliases

The comments above did not match. For the sake of explaining, it is
better to put the named aliases first.

Commits
-------

5052a37 Swap aliases

@greg0ire greg0ire deleted the greg0ire:swap-comments branch Apr 10, 2019

@greg0ire

This comment has been minimized.

Copy link
Contributor Author

commented Apr 10, 2019

Thanks for your quick fixes!

No problem, sorry for committing this in the first place!

I assume the order doesn't matter in real life projects? (maybe that's usefull to add, but I'm not sure)

I don't think it is but I don't know for sure, maybe @nicolas-grekas or @tgalopin can confirm.

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

corretc: the order doesn't matter

@greg0ire

This comment has been minimized.

Copy link
Contributor Author

commented Apr 10, 2019

That means I'm done! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.