Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encore: add guide to use Encore in a virtual machine #11422

Open
wants to merge 3 commits into
base: 3.4
from

Conversation

Projects
None yet
4 participants
@Kocal
Copy link
Contributor

Kocal commented Apr 13, 2019

Hi,

As the title says, this PR add a new guide for using Encore in a virtual machine.

This is what we use on ours Symfony apps at work which run inside a Vagrant VM.
It works really fine and I thought it would be helpful to share it with other people.

Also, I've removed a sub-section in the actual doc because according to symfony/webpack-encore#277, it was not working because some additional configuration was missing (and I can confirm it because I'm one of his co-worker 😛).

Kocal added some commits Apr 13, 2019

Encore: remove not really useful section for using dev-server inside …
…a VM

Even with the current doc, some people were not able to make it works in a VM, see symfony/webpack-encore#277.
@javiereguiluz
Copy link
Member

javiereguiluz left a comment

Nice! This was always a bit obscure and I'm glad that some Encore expert is contributing new docs for it. Thanks.

Show resolved Hide resolved frontend/encore/virtual-machine.rst Outdated
Encore.configureWatchOptions(watchOptions => {
watchOptions.poll = 250; // check for changes every 250 ms
});

This comment has been minimized.

Copy link
@Lyrkan

Lyrkan Apr 14, 2019

Contributor

Maybe also add a note here about the CLI equivalent (--watch-poll)?

This comment has been minimized.

Copy link
@Kocal

Kocal Apr 15, 2019

Author Contributor

Yep why not, but it means that the user will have to pass --watch-poll two times in its package.json 😕

Show resolved Hide resolved frontend/encore/virtual-machine.rst
Show resolved Hide resolved frontend/encore/virtual-machine.rst
Show resolved Hide resolved frontend/encore/virtual-machine.rst
@Kocal

This comment has been minimized.

Copy link
Contributor Author

Kocal commented Apr 15, 2019

Thanks @javiereguiluz and @Lyrkan, reviews have been applied :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.