Skip to content

[Workflow] Remove duplicate code in example #11547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2019
Merged

[Workflow] Remove duplicate code in example #11547

merged 1 commit into from
May 9, 2019

Conversation

welcoMattic
Copy link
Member

No description provided.

OskarStark
OskarStark approved these changes May 9, 2019
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@OskarStark OskarStark added this to the 4.2 milestone May 9, 2019
@OskarStark
Copy link
Contributor

Thank you @welcoMattic.

@OskarStark OskarStark merged commit a647732 into symfony:4.2 May 9, 2019
OskarStark added a commit that referenced this pull request May 9, 2019
@OskarStark
minor #11547 [Workflow] Remove duplicate code in example (welcoMattic)
9b9e98f 
This PR was merged into the 4.2 branch.

Discussion
----------

[Workflow] Remove duplicate code in example

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

a647732 Remove duplicate code in example
@welcoMattic welcoMattic deleted the patch-3 branch May 9, 2019 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

+1 more reviewer

@lyrixx lyrixx lyrixx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Status: Reviewed Workflow
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@welcoMattic @OskarStark @lyrixx @carsonbot