[Console] allow the answer to not be trimmed #11603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jul 8, 2019
…(Simperfit) This PR was merged into the 4.4 branch. Discussion ---------- [Console] allow answer to be trimmed by adding a flag | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | none <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#11603 <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> According to #23210 (comment) we add a new flag in the `Question` class to be able to not trim the answer. Commits ------- 8f182d8 [Console] allow answer to be trimmed by adding a flag
symfony-splitter
pushed a commit
to symfony/console
that referenced
this pull request
Jul 8, 2019
…(Simperfit) This PR was merged into the 4.4 branch. Discussion ---------- [Console] allow answer to be trimmed by adding a flag | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | none <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#11603 <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> According to symfony/symfony#23210 (comment) we add a new flag in the `Question` class to be able to not trim the answer. Commits ------- 8f182d811e [Console] allow answer to be trimmed by adding a flag
maxhelias
approved these changes
Aug 8, 2019
OskarStark
reviewed
Aug 8, 2019
OskarStark
reviewed
Aug 8, 2019
OskarStark
reviewed
Aug 8, 2019
Simperfit
force-pushed
the
feature/allow-answer-to-be-trimmed
branch
from
7c2e9cf
to
ce28de7
Compare
|
updated @OskarStark |
OskarStark
reviewed
Aug 8, 2019
OskarStark
approved these changes
Aug 9, 2019
OskarStark
force-pushed
the
feature/allow-answer-to-be-trimmed
branch
from
1f98bfc
to
dcb0eaa
Compare
|
Thank you Hamza. |
OskarStark
added a commit
that referenced
this pull request
Aug 9, 2019
This PR was squashed before being merged into the 4.4 branch (closes #11603). Discussion ---------- [Console] allow the answer to not be trimmed <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> This documents the new flag in the Question class to allow the answer to not be trimmed Commits ------- dcb0eaa [Console] allow the answer to not be trimmed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documents the new flag in the Question class to allow the answer to not be trimmed