Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reference][HttpClient] Auth basic is a scalar type #11676

Merged
merged 1 commit into from Jun 6, 2019

Conversation

Projects
None yet
5 participants
@spike31
Copy link
Contributor

commented Jun 5, 2019

Auth basic is a scalar type

@spike31 spike31 changed the base branch from master to 4.3 Jun 5, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

an array works too :)

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

oh no, not using configuration!

@javiereguiluz

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

Are we 100% sure about this? It as a string at first but then was changed to an array, right?

@OskarStark

This comment has been minimized.

@OskarStark OskarStark added this to the 4.3 milestone Jun 6, 2019

@OskarStark

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

Thank you @spike31 for taking care of this regression.

@OskarStark OskarStark merged commit fdd5e02 into symfony:4.3 Jun 6, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
symfony SymfonyCloud: Environment deployed
Details

OskarStark added a commit that referenced this pull request Jun 6, 2019

bug #11676 [Reference][HttpClient] Auth basic is a scalar type (spike31)
This PR was merged into the 4.3 branch.

Discussion
----------

[Reference][HttpClient] Auth basic is a scalar type

Auth basic is a scalar type

Commits
-------

fdd5e02 auth_basic is a scalar type

@spike31 spike31 deleted the spike31:fix_wrong_type_http_client branch Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.