[Reference][HttpClient] Auth basic is a scalar type #11676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
an array works too :) |
|
oh no, not using configuration! |
nicolas-grekas
approved these changes
Jun 5, 2019
OskarStark
approved these changes
Jun 5, 2019
|
Are we 100% sure about this? It as a string at first but then was changed to an array, right? |
|
|
Thank you @Spike31 for taking care of this regression. |
OskarStark
added a commit
that referenced
this pull request
Jun 6, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [Reference][HttpClient] Auth basic is a scalar type Auth basic is a scalar type Commits ------- fdd5e02 auth_basic is a scalar type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auth basic is a scalar type