#27345 Added Symfony\Component\Lock\Store\MongoDbStore #11735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kralos
force-pushed
the
27345-added-lock-mongodb-store
branch
from
afab849
to
02493d3
Compare
|
|
OskarStark
reviewed
Aug 22, 2019
OskarStark
reviewed
Aug 22, 2019
OskarStark
reviewed
Aug 22, 2019
OskarStark
reviewed
Aug 22, 2019
kralos
force-pushed
the
27345-added-lock-mongodb-store
branch
from
5f7b165
to
13bddeb
Compare
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Dec 11, 2019
This PR was submitted for the 4.4 branch but it was squashed and merged into the 5.1-dev branch instead (closes #31889). Discussion ---------- [Lock] add mongodb store | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes (requires `ext-mongodb` and `mongodb/mongodb` to test) | Fixed tickets | #27345 | License | MIT | Original Doc PR | symfony/symfony-docs#9807 | Remove from 4.3 Doc PR | symfony/symfony-docs#11686 | Add to 4.4 Doc PR | symfony/symfony-docs#11735 Looks like I messed up `kralos:27345-lock-mongodb` with a force push (trying to fix ci issues) right before it was merged to `master` (`4.3.0`). see #27648 **Description** We should support Semaphore Locks with a MongoDB back end to allow those that already use MongoDB as a distributed storage engine. Symfony already partially supports MongoDB for session storage: `Symfony\Component\HttpFoundation\Session\Storage\Handler\MongoDbSessionHandler` **Example** ```php $client = new MongoDb\Client(); $store = new Symfony\Component\Lock\Store\MongoDbStore( $client array( 'database' => 'my-app', ) ); $lockFactory = new Symfony\Component\Lock\Factory($store); $lock = $lockFactory->createLock('my-resource'); ``` Commits ------- a6bfa59 [Lock] add mongodb store
kralos
force-pushed
the
27345-added-lock-mongodb-store
branch
from
ab51419
to
e8d6e49
Compare
|
Since @fabpot just merged symfony/symfony#31889 I've re-based this from |
kralos
force-pushed
the
27345-added-lock-mongodb-store
branch
from
8087cd4
to
392140a
Compare
kralos
force-pushed
the
27345-added-lock-mongodb-store
branch
from
392140a
to
679a77e
Compare
|
The code for this has been merged into |
OskarStark
reviewed
Feb 17, 2020
OskarStark
approved these changes
Feb 21, 2020
OskarStark
requested review from
HeahDude
and removed request for
javiereguiluz
javiereguiluz
force-pushed
the
27345-added-lock-mongodb-store
branch
from
da1382e
to
cc02ab4
Compare
javiereguiluz
approved these changes
Apr 10, 2020
There was a problem hiding this comment.
@kralos thanks a lot for your contribution. I tried to merge it with the internal tool we use to merge Symfony PRs ... but I faced an error that I couldn't fix myself. So, could you please rebase your PR one last time? Thanks!
kralos
force-pushed
the
27345-added-lock-mongodb-store
branch
from
cc02ab4
to
934401f
Compare
|
@javiereguiluz I've fixed the branch, also noticed the DBAL link was broken (Doctrine dropped the DBAL dir using psr-4) so i've updated it |
|
Merged! Thanks a lot for the extra effort needed to rebase and get this PR ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Lock MongoDbStore documentation to symfony 5.1