Skip to content

Removed "experimental" notices in some components #11857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2019
Merged

Removed "experimental" notices in some components #11857

merged 1 commit into from
Jul 3, 2019

Conversation

javiereguiluz
Copy link
Member

Fixes #11852.

@javiereguiluz javiereguiluz added this to the 4.4 milestone Jul 1, 2019
OskarStark
OskarStark reviewed Jul 2, 2019
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am against removing the whole versionadded directives, but only the part of the „experimental“

@javiereguiluz
Copy link
Member Author

Oskar, you are right! The "versionadded" directives must be maintained in all minor versions of the same branch, so 4.4 contains "added in 4.3". We must remove them in master, which is 5.0.

@javiereguiluz javiereguiluz merged commit 6a9dc1b into symfony:4.4 Jul 3, 2019
javiereguiluz added a commit that referenced this pull request Jul 3, 2019
@javiereguiluz
minor #11857 Removed "experimental" notices in some components (javie…
2232568 
…reguiluz)

This PR was squashed before being merged into the 4.4 branch (closes #11857).

Discussion
----------

Removed "experimental" notices in some components

Fixes #11852.

Commits
-------

6a9dc1b Removed \"experimental\" notices in some components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@javiereguiluz @OskarStark @xabbuh @carsonbot