Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented the ErrorRenderer component #11864

Closed
wants to merge 4 commits into from

Conversation

javiereguiluz
Copy link
Member

This fixes #11837.

I'll need help for some things:

  • I don't understand well how this component is enabled/disabled/configured both as a stand-alone component and inside a Symfony application.
  • I'm not sure if I removed the right things from Debug component. Should we make more changes?

Thanks.

Copy link
Member

@yceruto yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick review.

Thank you for caring about this!

components/error_catcher.rst Outdated Show resolved Hide resolved
components/error_catcher.rst Outdated Show resolved Hide resolved
components/error_catcher.rst Outdated Show resolved Hide resolved
components/error_catcher.rst Outdated Show resolved Hide resolved
@javiereguiluz javiereguiluz changed the title Documented the ErrorCatcher component Documented the ErrorRenderer component Jul 12, 2019
@yceruto
Copy link
Member

yceruto commented Jul 12, 2019

This document needs to be divided, now the ErrorRenderer component contains only the renderer layer and the new ErrorHandler component (symfony/symfony#32471) contains the handlers.

@OskarStark
Copy link
Contributor

@yceruto is this still necessary or can we close this PR?

@yceruto
Copy link
Member

yceruto commented Aug 15, 2019

I think the ErrorRenderer part is still good. I will try to update it according to the latest changes.

@yceruto
Copy link
Member

yceruto commented Aug 16, 2019

See #12187, Javier, feel free to continue your work there.

@javiereguiluz
Copy link
Member Author

Let's close this in favor of #12187.

javiereguiluz added a commit that referenced this pull request Sep 19, 2019
…aviereguiluz, yceruto)

This PR was merged into the 4.4 branch.

Discussion
----------

Documenting ErrorRenderer and ErrorHandler components

Replace #11864
Closes #12193 #12009 #11980 #12015 #12019 #12029

Should we remove the whole Debug component documentation? or remove only the details and say it's deprecated?

Commits
-------

8cc084f documenting the ErrorHandler::call method
3ea9817 fix service definition
5a025c9 fix example
5136a17 Update with latest changes: ErrorRenderer and ErrorHandler components
b0723ef Fixed a method name
b600b3c Renamed ErrorCatcher as ErrorRenderer
4e333c1 Fixes
b2a1a9b Documented the ErrorCatcher component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants