Skip to content

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 15, 2019

A value can only be either less than the min or greater than the max
allowed value.

@xabbuh xabbuh added this to the 4.4 milestone Jul 15, 2019
@xabbuh
Copy link
Member Author

xabbuh commented Jul 15, 2019

ping @Lctrs

A value can only be either less than the min or greater than the max
allowed value.
@Lctrs
Copy link
Contributor

Lctrs commented Jul 15, 2019

@xabbuh
Copy link
Member Author

xabbuh commented Jul 15, 2019

@Lctrs Thank you. 👍

@Lctrs
Copy link
Contributor

Lctrs commented Jul 15, 2019

@xabbuh Can you also change the description of the maxMessage option to use greater instead of more ?

EDIT : Should be in its own PR targeting 3.4 instead.

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both are technically correct, but "greater" is more common:

image

@javiereguiluz
Copy link
Member

Thanks.

@javiereguiluz javiereguiluz merged commit 6165d07 into symfony:4.4 Jul 16, 2019
javiereguiluz added a commit that referenced this pull request Jul 16, 2019
This PR was merged into the 4.4 branch.

Discussion
----------

fix description

A value can only be either less than the min or greater than the max
allowed value.

Commits
-------

6165d07 fix description
@xabbuh xabbuh deleted the pr-11953 branch July 16, 2019 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants