-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Updated related to Symfony installation and Symfony Flex #12119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhelias
reviewed
Aug 8, 2019
maxhelias
approved these changes
Aug 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great :)
fabpot
requested changes
Aug 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
e1a80ad
to
e614ed1
Compare
javiereguiluz
added a commit
that referenced
this pull request
Aug 10, 2019
… (javiereguiluz) This PR was squashed before being merged into the 4.3 branch (closes #12119). Discussion ---------- Updated related to Symfony installation and Symfony Flex Don't merge this yet ... because it needs some changes in symfony.com/download too. ----- I think the new docs are better because: * Symfony Local Server articles only talks about server, not security:check and creating apps. * Flex is explained in the main setup article ... and /setup/flex is left as the article explaining how to upgrade old apps to Flex * We now talk about "Install Symfony", to simplify the explanations around "the Symfony binary", which in the past we called it "binary", "CLI", "server", "local server", etc. * The main setup + installation article shows Composer installation too, to avoid issues for people who can't install Symfony. * We only have a single place where we show how to create Symfony apps with the Symfony binary and Composer (the main /setup article) instead of showing that in multiple places. * We remove some internal details about Flex recipes which are already explained in the recipes repository. Commits ------- e614ed1 Updated related to Symfony installation and Symfony Flex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge this yet ... because it needs some changes in symfony.com/download too.
I think the new docs are better because: