Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflow] Removed note about flushing in `entered` event #12413

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@lyrixx
Copy link
Member

commented Oct 3, 2019

This sentence is confusing and lead to bad practices:

  • It's not a good idea to flush in the model layer
  • It can lead to many calls to flush() method if the user uses a workflow (with many to places after a transition)
  • It's not possible to "preview" what a transition do, because everything is flushed in the DB
This sentence is confusing and lead to bad practices:

* It's not a good idea to flush in the model layer
* It can lead to many calls to `flush()` method if the user uses a workflow (with many `to` places after a transition)
* It's not possible to "preview" what a transition do, because everything is flushed in the DB
@javiereguiluz

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

Thanks Grégoire.

javiereguiluz added a commit that referenced this pull request Oct 3, 2019
…t (lyrixx)

This PR was merged into the 3.4 branch.

Discussion
----------

[Workflow] Removed note about flushing in `entered` event

This sentence is confusing and lead to bad practices:

* It's not a good idea to flush in the model layer
* It can lead to many calls to `flush()` method if the user uses a workflow (with many `to` places after a transition)
* It's not possible to "preview" what a transition do, because everything is flushed in the DB

Commits
-------

d7511a1 [Workflow] Removed note about flushing in `entered` event
@javiereguiluz javiereguiluz merged commit d7511a1 into symfony:3.4 Oct 3, 2019
3 checks passed
3 checks passed
DOCtor-RST
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
symfony SymfonyCloud: Environment deployed
Details
@lyrixx lyrixx deleted the lyrixx:patch-1 branch Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.