Skip to content

Fixed problem normalizer example #12860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2020
Merged

Conversation

andrew-demb
Copy link
Contributor

No description provided.

@atailouloute
Copy link
Contributor

I think you should 4.4 as the base branch for this PR not master.
It's the lowest maintained version with this problem

@javiereguiluz javiereguiluz changed the base branch from master to 4.4 January 2, 2020 10:00
@javiereguiluz
Copy link
Member

@andrew-demb thanks for fixing this error! @atailouloute you are right! We changed the branch to 4.4 while merging. Thanks.

javiereguiluz added a commit that referenced this pull request Jan 2, 2020
This PR was submitted for the master branch but it was merged into the 4.4 branch instead (closes #12860).

Discussion
----------

Fixed problem normalizer example

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

72ac457 Fixed problem normalizer example
@javiereguiluz javiereguiluz merged commit 72ac457 into symfony:4.4 Jan 2, 2020
@andrew-demb andrew-demb deleted the patch-2 branch January 2, 2020 12:55
@andrew-demb
Copy link
Contributor Author

Thank you both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants