Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[String] Documented the s() function #13119

Merged
merged 1 commit into from Feb 13, 2020
Merged

Conversation

@javiereguiluz
Copy link
Member

javiereguiluz commented Feb 12, 2020

Fixes #13068.

@javiereguiluz javiereguiluz added this to the 5.1 milestone Feb 12, 2020
@OskarStark

This comment has been minimized.

Copy link
Contributor

OskarStark commented Feb 13, 2020

Thank you Javier.

OskarStark added a commit that referenced this pull request Feb 13, 2020
This PR was merged into the master branch.

Discussion
----------

[String] Documented the s() function

Fixes #13068.

Commits
-------

850c347 [String] Documented the s() function
@OskarStark OskarStark merged commit 850c347 into symfony:master Feb 13, 2020
3 checks passed
3 checks passed
Build
Details
DOCtor-RST
Details
symfony SymfonyCloud: Environment deployed
Details
use function Symfony\Component\String\u;

// creates a ByteString object
$foo = s('\xfe\xff');

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Feb 13, 2020

Member

Double quotes would be needed for escaped chars to be parsed

This comment has been minimized.

Copy link
@OskarStark

OskarStark Feb 13, 2020

Contributor

Will fix it

This comment has been minimized.

Copy link
@OskarStark
OskarStark added a commit that referenced this pull request Feb 13, 2020
This PR was merged into the master branch.

Discussion
----------

[String] Fix s() namespace

Ref #13119

Commits
-------

4a52c6e [String] Fix s() namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.