Skip to content

Add note about final classes #13157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Add note about final classes #13157

wants to merge 4 commits into from

Conversation

OskarStark
Copy link
Contributor

Screenshot 2020-02-17 08 56 05

@OskarStark OskarStark added this to the 3.4 milestone Feb 17, 2020
noniagriconomie
noniagriconomie reviewed Feb 17, 2020
View reviewed changes
HeahDude
HeahDude reviewed Feb 17, 2020
View reviewed changes
ghost
ghost approved these changes Feb 17, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

√

wouterj
wouterj approved these changes Feb 17, 2020
View reviewed changes
OskarStark and others added 2 commits February 18, 2020 06:58
@OskarStark @wouterj
Reword
d1f77bd 
Co-Authored-By: Wouter J <wouterj@users.noreply.github.com>
@OskarStark
Link to final keyword in php docs
0c51658
@OskarStark OskarStark requested a review from wouterj February 18, 2020 05:59
OskarStark added a commit that referenced this pull request Feb 18, 2020
@OskarStark
minor #13157 Add note about final classes (OskarStark)
e5e04ff 
This PR was squashed before being merged into the 3.4 branch.

Discussion
----------

Add note about final classes

![Screenshot 2020-02-17 08 56 05](https://user-images.githubusercontent.com/995707/74634030-57827100-5163-11ea-8276-2d6bac34a951.png)

Commits
-------

2743d6f Add note about final classes
@HeahDude
Copy link
Contributor

Closing this one as it's been merged already.

@HeahDude HeahDude closed this Feb 18, 2020
@wouterj wouterj deleted the final branch February 18, 2020 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj Awaiting requested review from wouterj

3 more reviewers

@noniagriconomie noniagriconomie noniagriconomie left review comments

@HeahDude HeahDude HeahDude approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
DependencyInjection Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
5 participants
@OskarStark @HeahDude @wouterj @noniagriconomie @carsonbot