Skip to content

using slugger for file uploading, instead of long transliterator code #13408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2020
Merged

using slugger for file uploading, instead of long transliterator code #13408

merged 1 commit into from
Mar 24, 2020

Conversation

weaverryan
Copy link
Member

String is new in 5.0 and a dependency of FrameworkBundle. And so, a SluggerInterface service is always available. We can use it :)

Thanks!

wouterj
wouterj approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@wouterj wouterj added this to the 5.0 milestone Mar 24, 2020
@javiereguiluz
Copy link
Member

Much better! Thanks Ryan.

@javiereguiluz javiereguiluz merged commit f31423d into 5.0 Mar 24, 2020
@javiereguiluz javiereguiluz deleted the weaverryan-patch-1 branch March 24, 2020 10:56
@nlemoine nlemoine mentioned this pull request Mar 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@weaverryan @javiereguiluz @wouterj @carsonbot