Skip to content

Add warning on Docker integration #14381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2020
Merged

Add warning on Docker integration #14381

merged 1 commit into from
Oct 30, 2020

Conversation

qdequippe
Copy link
Contributor

A small warning to avoid drop database/data of your dev environment :)

noniagriconomie
noniagriconomie reviewed Oct 9, 2020
View reviewed changes
wouterj
wouterj approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this is something we have to document 👍

@wouterj wouterj added this to the 3.4 milestone Oct 22, 2020
@OskarStark OskarStark modified the milestones: 3.4, 4.4 Oct 30, 2020
@OskarStark OskarStark changed the base branch from 5.1 to 4.4 October 30, 2020 12:54
@OskarStark
Copy link
Contributor

OskarStark commented Oct 30, 2020 •
edited
Loading

Thank you Quentin, I merged this into 4.4 branch 👍

@OskarStark OskarStark merged commit 9769f6d into symfony:4.4 Oct 30, 2020
@qdequippe qdequippe deleted the patch-1 branch October 30, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

@HeahDude HeahDude Awaiting requested review from HeahDude

@xabbuh xabbuh Awaiting requested review from xabbuh

+1 more reviewer

@noniagriconomie noniagriconomie noniagriconomie left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@qdequippe @OskarStark @wouterj @noniagriconomie @carsonbot