[RateLimiter][Security] Document login throttling and clarify DoS protection #14918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
wouterj
force-pushed
the
rate-limiter-use-case
branch
from
201c6d8 to
a1b7df0
Compare
javiereguiluz
approved these changes
Feb 3, 2021
carsonbot
changed the title
wouterj
force-pushed
the
rate-limiter-use-case
branch
from
a1b7df0 to
a2be7b8
Compare
javiereguiluz
force-pushed
the
rate-limiter-use-case
branch
from
a2be7b8 to
88a52da
Compare
|
Thank you Wouter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR started as "clarifying Symfony's rate limiter use-case compared to rate limiters outside PHP" (first commit).
I wanted to also add some guidelines on brute force attack protection beyond limiting login attempts, but discovered login throttling wasn't documented yet. So this PR now also documents login throttling :)
Fixes #14251