Skip to content

[Security] Fixes typo in experimental authenticators #15286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2021
Merged

[Security] Fixes typo in experimental authenticators #15286

merged 1 commit into from
Apr 26, 2021

Conversation

jmleroux
Copy link
Contributor

$email was not defined in the example.

Nyholm
Nyholm approved these changes Apr 24, 2021
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thank you for fixing this.

@OskarStark OskarStark added this to the 5.2 milestone Apr 26, 2021
@jmleroux @OskarStark
[Security] Fixes typo in experimental authenticators
0df9393 
`$email` was not defined in the example.
@OskarStark OskarStark changed the base branch from 5.x to 5.2 April 26, 2021 08:15
@OskarStark OskarStark requested a review from xabbuh as a code owner April 26, 2021 08:15
@OskarStark
Copy link
Contributor

Good catch, thanks @jmleroux.

@OskarStark OskarStark merged commit 618dba4 into symfony:5.2 Apr 26, 2021
@jmleroux jmleroux deleted the patch-1 branch April 27, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

+1 more reviewer

@Nyholm Nyholm Nyholm approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Security Status: Needs Review
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
4 participants
@jmleroux @OskarStark @Nyholm @carsonbot